Ticket #48 (new defect)

Opened 4 months ago

Last modified 4 months ago

TCON (genre) not set with Max, here is easy fix

Reported by: johnbuckman Owned by:
Priority: major Milestone:
Version: 0.8.1 Keywords: tcon genre
Cc:

Description

The id3 tag TCON is not being set correctly in Max.

I believe the bug is very simple to fix, as Max is passing the text of the genre, and not the number.

If I pick "Ambient" as a genre, and rip, id3v2 tells me TCON is unknown.

However, if I hand-type "26" into the "Genre" field in Max, and rip, then id3v2 correctly shows me that the mp3 created by max is set to TCON=Ambient.

So... look in your source code, and simply swap the variables -- be sure you're sending the TCON genre number, and not the text, and this bug should go away.

Change History

Changed 4 months ago by sbooth

What are you using to display the ID3 tag info? According to the ID3v2.4 specs at http://id3.org/id3v2.4.0-frames, TCON may be a number or a string:

TCON
   The 'Content type', which ID3v1 was stored as a one byte numeric
   value only, is now a string. You may use one or several of the ID3v1
   types as numerical strings, or, since the category list would be
   impossible to maintain with accurate and up to date categories,
   define your own. Example: "21" $00 "Eurodisco" $00

   You may also use any of the following keywords:
   
     RX  Remix
     CR  Cover

It is debatable whether Max should use numbers for pre-defined genres from ID3v1, but I believe that any ID3v2.4 compliant program should handle numbers or strings in TCON.

Note: See TracTickets for help on using tickets.